[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Mitch Phillips via Phabricator via libc-commits]

hctim accepted this revision.
hctim added a comment.
This revision is now accepted and ready to land.

Have you tested that GWP-ASan works? I know your test runner can't capture stderr/stdout right now, but can you link a program with scudo+llvm-libc+gwp-asan and run a malloc->free->uaf loop and see GWP-ASan crash? Something like `compiler-rt/test/gwp_asan/use_after_free.cpp`.



================
Comment at: libc/lib/CMakeLists.txt:6
+  if(NOT (LIBC_TARGET_ARCHITECTURE IN_LIST ALL_SCUDO_STANDALONE_SUPPORTED_ARCH))
+    message(FATAL_ERROR "Architecture ${LIBC_TARGET_ARCHITECTURE} is not supported by SCUDO. Either disable LLVM_LIBC_INCLUDE_SCUDO or change your target architecture.")
+  endif()
----------------
nit: break across multiple lines


================
Comment at: libc/lib/CMakeLists.txt:10
+  if((LIBC_TARGET_ARCHITECTURE IN_LIST ALL_GWP_ASAN_SUPPORTED_ARCH) AND COMPILER_RT_BUILD_GWP_ASAN)
+    list(APPEND SCUDO_DEPS RTGwpAsan.${LIBC_TARGET_ARCHITECTURE} RTGwpAsanBacktraceLibc.${LIBC_TARGET_ARCHITECTURE} RTGwpAsanSegvHandler.${LIBC_TARGET_ARCHITECTURE})
+  elseif(COMPILER_RT_BUILD_GWP_ASAN)
----------------
nit: break across multiple lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919