[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: compiler-rt/cmake/config-ix.cmake:703
+if(SCUDO_STANDALONE_SUPPORTED_ARCH)
+  set(SCUDO_STANDALONE_BUILD_OBJECTS TRUE)
+else()
----------------
hctim wrote:
> why create a copy of `SCUDO_STANDALONE_SUPPORTED_ARCH`?
I figured it was probably better to condition off of a proper bool as opposed to a list, but if we're not using this at all then I can remove it.


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:79-81
+endif()
 
+if(GWP_ASAN_BUILD_OBJECTS)
----------------
hctim wrote:
> can revert this diff now that COMPILER_RT_HAS_GWP_ASAN is back to being the source of truth
`COMPILER_RT_HAS_GWP_ASAN` being the source of truth is useful, but from what I can tell it's still conditioned on the compiler-rt supported architectures. The problem there is that I don't see an easy way to tell compiler-rt that you want to compile for an architecture that isn't the current one. If there's a cmake flag to do that that I have missed, then that would be very helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919