[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Mitch Phillips via Phabricator via libc-commits]

hctim added inline comments.


================
Comment at: compiler-rt/cmake/config-ix.cmake:703
+if(SCUDO_STANDALONE_SUPPORTED_ARCH)
+  set(SCUDO_STANDALONE_BUILD_OBJECTS TRUE)
+else()
----------------
why create a copy of `SCUDO_STANDALONE_SUPPORTED_ARCH`?


================
Comment at: compiler-rt/cmake/config-ix.cmake:747
 # for Scudo and GWP-ASan, further testing needed.
-if (COMPILER_RT_HAS_SANITIZER_COMMON AND GWP_ASAN_SUPPORTED_ARCH AND
+if (COMPILER_RT_HAS_SANITIZER_COMMON AND GWP_ASAN_SUPPORTED_ARCH AND COMPILER_RT_BUILD_GWP_ASAN AND
     OS_NAME MATCHES "Linux")
----------------
remove this


================
Comment at: compiler-rt/cmake/config-ix.cmake:755-759
+if (GWP_ASAN_SUPPORTED_ARCH AND COMPILER_RT_BUILD_GWP_ASAN)
+  set(GWP_ASAN_BUILD_OBJECTS TRUE)
+else()
+  set(GWP_ASAN_BUILD_OBJECTS FALSE)
+endif()
----------------
not necessary if we delete COMPILER_RT_HAS_SANITIZER_COMMON, then we can guard things by COMPILER_RT_HAS_GWP_ASAN


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:36
 # parts of the C++ standard library.
 set(GWP_ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS} -fno-rtti -fno-exceptions
     -nostdinc++ -pthread -fno-omit-frame-pointer)
----------------
remove this


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:39
 append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC GWP_ASAN_CFLAGS)
 
 # Remove -stdlib= which is unused when passing -nostdinc++.
----------------
add `append_list_if(COMPILER_RT_HAS_SANITIZER_COMMON, ${SANITIZER_COMMON_CFLAGS} GWP_ASAN_CFLAGS)`


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:79-81
+endif()
 
+if(GWP_ASAN_BUILD_OBJECTS)
----------------
can revert this diff now that COMPILER_RT_HAS_GWP_ASAN is back to being the source of truth


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919