[libc-commits] [PATCH] D106919: [libc][wip] add integration tests for scudo in libc

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/CMakeLists.txt:81
 
+if(GWP_ASAN_BUILD_OBJECTS)
   add_compiler_rt_object_libraries(RTGwpAsan
----------------
sivachandra wrote:
> If GWP-ASan is a standalone (as it does not depend on rest of compiler-rt), can we add the following object libraries unconditionally with `ARCHS ${ALL_GWP_ASAN_SUPPORTED_ARCH}`? Otherwise, there is again a disconnect between GWP-ASan build and libc build - GWP-ASan object libraries are condition to `GWP_ASAN_BUILD_OBJECTS`, which depends on `GWP_ASAN_SUPPORTED_ARCH`, which in turn depends on `COMPILER_RT_SUPPORTED_ARCH`. May be we can even add the above runtime libraries also unconditionally?
> 
If I set this to `ARCHS ${ALL_GWP_ASAN_SUPPORTED_ARCH}` then I get errors due to the supported platform checking in the `add_compiler_rt_object_libraries` function. Without modifying that I simply cannot tell it to build for archs not supported by compiler-rt as a whole. If we made a change (such as adding a new function for building just object libraries for all possible archs) I think adding the libraries unconditionally would be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106919/new/

https://reviews.llvm.org/D106919