[libc-commits] [PATCH] D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function.

[Tue Ly via Phabricator via libc-commits]

lntue marked 3 inline comments as done.
lntue added inline comments.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:544
+  return (ulp < ulpError) ||
+         ((ulp == ulpError) && ((ulp != 0.5) || bitsAreEven));
+}
----------------
sivachandra wrote:
> This is now repeated in two other functions also I think. We should probably use a helper function, but can be done in a later pass.
Ack


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87514/new/

https://reviews.llvm.org/D87514