[libc-commits] [PATCH] D87514: [libc] Extend MPFRMatcher to handle 2-input-1-output and support hypot function.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.cpp:544
+  return (ulp < ulpError) ||
+         ((ulp == ulpError) && ((ulp != 0.5) || bitsAreEven));
+}
----------------
This is now repeated in two other functions also I think. We should probably use a helper function, but can be done in a later pass.


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.h:50
   BeginBinaryOperationsSingleOutput,
   // TODO: Add operations like hypot.
+  Hypot,
----------------
Can you remove the TODO?


================
Comment at: libc/utils/MPFRWrapper/MPFRUtils.h:167
   static bool match(const BinaryInput<T> &in, T out, double tolerance) {
     // TODO: Implement the comparision function and error reporter.
+    return compareBinaryOperationOneOutput(op, in, out, tolerance);
----------------
Can you remove the TODO here as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87514/new/

https://reviews.llvm.org/D87514