[libc-commits] [PATCH] D80265: [libc] Make clang-tidy use host compiler's resource dir.

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu May 21 16:49:05 PDT 2020


PaulkaToast added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:228
+    else()
+      set(restrict_system_headers_check_invocation "")
+    endif()
----------------
sivachandra wrote:
> Instead of leaving it empty, may be:
> 
> ```
> COMMAND ${CMAKE_COMMAND} -E echo "Header file check skipped"
> ```
> 
> Not sure if it is going to get too noisy. Other option is to append this message to the `COMMENT` of the custom command.
I tried it out and it doesn't seem too noisy to me. Thanks for the suggestion! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80265/new/

https://reviews.llvm.org/D80265





More information about the libc-commits mailing list