[libc-commits] [PATCH] D80265: [libc] Make clang-tidy use host compiler's resource dir.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/CMakeLists.txt:66
+
+# Check --print-resource-dir to find the compiler resource dir if this flag
+# is supported by the compiler.
----------------
Can you move this to right before/after the linting related code.


================
Comment at: libc/cmake/modules/LLVMLibCObjectRules.cmake:228
+    else()
+      set(restrict_system_headers_check_invocation "")
+    endif()
----------------
Instead of leaving it empty, may be:

```
COMMAND ${CMAKE_COMMAND} -E echo "Header file check skipped"
```

Not sure if it is going to get too noisy. Other option is to append this message to the `COMMENT` of the custom command.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80265/new/

https://reviews.llvm.org/D80265