[libc-commits] [PATCH] D76826: [libc] Extend add_object rule to handle helper object libraries.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Mar 28 00:30:32 PDT 2020

sivachandra marked 2 inline comments as done.
sivachandra added inline comments.

Comment at: libc/cmake/modules/LLVMLibCRules.cmake:238
+        # Even from among the visible targets, we will collect object files
+        # only from add_object_library targets.
+        continue()
abrachet wrote:
> Why not from add_entrypoint_object targets?
Essentially to avoid inconsistency. Either we get object files from all of the entrypoint deps, or from none of them. We cannot get from all of them as CMake might not have seen some of them yet. In case of object library deps though, we are enforcing that they be visible. This is not really a big ask as object libraries are usually helper libraries for a bunch of related functions.

That said, if we move to CMake 3.15, the widely expanded generator support could allow us to simplify and improve the situation here.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list