[libc-commits] [PATCH] D76826: [libc] Extend add_object rule to handle helper object libraries.
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Mar 26 16:52:48 PDT 2020
abrachet accepted this revision.
abrachet added inline comments.
This revision is now accepted and ready to land.
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:118
+ if(NOT ADD_OBJECT_SRCS)
message(FATAL_ERROR "'add_object' rules requires a SRC to be specified.")
Nit: this could say requires SRCS to be specified.
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:238
+ # Even from among the visible targets, we will collect object files
+ # only from add_object_library targets.
Why not from add_entrypoint_object targets?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits