[libc-commits] [PATCH] D76559: [libc] Enable llvmlibc clang-tidy checks

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Mar 21 19:46:45 PDT 2020

PaulkaToast marked 2 inline comments as done.
PaulkaToast added inline comments.

Comment at: libc/src/.clang-tidy:6
+  - key:             llvmlibc-restrict-system-libc-headers.Includes
+    value:           '-*, linux/*, asm/unistd.h'
abrachet wrote:
> Everything in `asm/*` should be safe, I imagine.
That's what I thought but it has stuff like https://elixir.bootlin.com/linux/latest/source/arch/x86/include/asm/string_32.h

which might be unsafe to include?

Comment at: libc/src/math/round_redirector.cpp:10
+// Include okay for this redirector.
+// NOLINTNEXTLINE(llvmlibc-restrict-system-libc-headers)
 #include <math.h>
abrachet wrote:
> Is it possible for value to be something like `*redirector*` so we don't need to manually add the nolint manually like this? Not that its a big deal as this is the only one.
I think it might be better to be on the safe side here and avoid a blanket "allow all includes in redirectors" sort of mechanism. Just to avoid accidentally making a mistake, thoughts?

  rG LLVM Github Monorepo



More information about the libc-commits mailing list