[libc-commits] [PATCH] D76559: [libc] Enable llvmlibc clang-tidy checks

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Mar 21 18:42:42 PDT 2020


abrachet added inline comments.


================
Comment at: libc/src/.clang-tidy:6
+  - key:             llvmlibc-restrict-system-libc-headers.Includes
+    value:           '-*, linux/*, asm/unistd.h'
----------------
Everything in `asm/*` should be safe, I imagine.


================
Comment at: libc/src/math/round_redirector.cpp:10
+// Include okay for this redirector.
+// NOLINTNEXTLINE(llvmlibc-restrict-system-libc-headers)
 #include <math.h>
----------------
Is it possible for value to be something like `*redirector*` so we don't need to manually add the nolint manually like this? Not that its a big deal as this is the only one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76559/new/

https://reviews.llvm.org/D76559





More information about the libc-commits mailing list