[libc-commits] [PATCH] D76267: [libc] Resolve race condition in sub-process test runner.
Alex Brachet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Mar 16 22:43:05 PDT 2020
abrachet accepted this revision.
abrachet added a comment.
LGTM. Sorry about that, I never caught this failing so thanks for catching it!
> however if the child closes the pipe intentionally then it could result in the test runner hanging. I find this situation less likely, where as I experience failures locally with this race condition rather consistently.
Agreed I don't think the death test would run `::close(4)`, and this is a more controlled environment so I think it is fine. If we want we can do the more traditional pattern of setting an alarm and sigwaiting for either `SIGALRM` or `SIGCHLD`, but I find signals very hacky.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits