[libc-commits] [PATCH] D76267: [libc] Resolve race condition in sub-process test runner.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Mar 16 22:43:03 PDT 2020


sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/utils/testutils/ExecuteFunctionUnix.cpp:73
+    return ProcessStatus::Error("waitpid(2) failed");
+  assert(status == Pid);
   (void)status;
----------------
At this point, this `assert` is probably pointless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76267/new/

https://reviews.llvm.org/D76267





More information about the libc-commits mailing list