[libc-commits] [PATCH] D75487: [libc] [UnitTest] Add Matchers

[Alex Brachet via Phabricator via libc-commits]

abrachet marked 7 inline comments as done.
abrachet added inline comments.


================
Comment at: libc/utils/UnitTest/ErrnoSetterMatcher.h:53
+
+namespace ErrnoSetterMatcher {
+
----------------
> These names are generic enough that some kind of specificity would be nice? I am not able to think of an alternate. May be ErrnoSetterSucceeds and ErrnoSetterFails?

What about this set up? I think it is nice to be able to use a `using` and refer to these as just `Succeeds` and `Fails` for brevity. No strong preference happy to call these `ErrnoSetterSucceeds/Fails`


================
Comment at: libc/utils/UnitTest/Matchers.h:16
+extern "C" const char *strerror(int);
+
+template <typename T>
----------------
sivachandra wrote:
> Why not enclose in `__llvm_libc::testing`? To avoid verbosity?
Good call.


================
Comment at: libc/utils/testutils/StreamWrapper.h:1
+//===------------------------ StreamWrapper.h -------------------*- C++ -*-===//
+//
----------------
sivachandra wrote:
> I don't necessarily like this, but can't think of an alternate. So, LGTM.
Agreed, it's not ideal, but I think it is required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75487/new/

https://reviews.llvm.org/D75487