[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D73337#1841025 <https://reviews.llvm.org/D73337#1841025>, @gchatelet wrote:

> In D73337#1841007 <https://reviews.llvm.org/D73337#1841007>, @abrachet wrote:
>
> > LGTM, I would wait for Siva though.
>
>
> Will do.
>
> > In D73337#1840856 <https://reviews.llvm.org/D73337#1840856>, @gchatelet wrote:
> > 
> >>
> > 
> > 
> > A little bit off topic, can you successfully build with make? A few weeks ago when I tried cmake was producing invalid Makefiles but ninja was fine. It broke for Siva too https://reviews.llvm.org/D72353#1808817
>
> Indeed if I compile with `make` I have the following error, not the same as yours though.
>
>   make[2]: *** No rule to make target 'projects/libc/src/sys/mman/linux/munmap.o', needed by 'projects/libc/lib/libllvmlibc.a'.  Stop.
>   make[2]: Leaving directory '/tmp/build'
>   make[1]: *** [CMakeFiles/Makefile2:23563: projects/libc/lib/CMakeFiles/llvmlibc.dir/all] Error 2
>
>
> I first thought it was an issue with `-j` option but even when building without the option it still fails with the same error message. It compiles fine with `Ninja` though.


I have not yet got to digging into the problems with `make`. As I said earlier, it is very likely a CMake problem/limitation. [Just guessing that we are using some feature which is pushing the limits of CMake's dependency analysis.]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337