[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Jan 26 13:52:13 PST 2020


sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

In D73337#1840853 <https://reviews.llvm.org/D73337#1840853>, @gchatelet wrote:

> - Address comments


Thanks for you patience. I really wish the `LINK_COMPONENTS` option was required for static and dynamic libraries. But, if dynamic libraries is a must going forward, I think I should include it in my normal patch testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337





More information about the libc-commits mailing list