[libc-commits] [PATCH] D74949: [libc] Create abort and _Exit

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/stdlib/abort.cpp:19
+  __llvm_libc::raise(SIGABRT);
+  __llvm_libc::raise(SIGKILL);
+  __llvm_libc::_Exit(127);
----------------
If there is a signal handler for SIGABRT, the code should try blocking the signal. Since signals are not available, this is fine.


================
Comment at: libc/src/stdlib/linux/_Exit.cpp:19
+  for (;;) {
+#ifdef SYS_exit_group
+    __llvm_libc::syscall(SYS_exit_group, status);
----------------
Which arch does not define `SYS_exit_group`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74949/new/

https://reviews.llvm.org/D74949