[libc-commits] [PATCH] D74949: [libc] Create abort and _Exit

Thu Feb 20 22:51:52 PST 2020

abrachet marked an inline comment as done.
abrachet added a comment.

There are no tests at the moment, although I have tested them. I am waiting for D74665 <https://reviews.llvm.org/D74665> (which I am waiting for D74652 <https://reviews.llvm.org/D74652> to hopeful reuse some code), but didn't want this patch to block on these. I'd be happy to rebase against D74665 <https://reviews.llvm.org/D74665> and add tests here though.

================
Comment at: libc/spec/stdc.td:175-176
+      [
+          FunctionSpec<"abort", RetValSpec<VoidType>, [ArgSpec<VoidType>]>,
+          FunctionSpec<"_Exit", RetValSpec<VoidType>, [ArgSpec<IntType>]>,
+      ]
----------------
These should both be `_Noreturn` or `__attribute__((noreturn))` I'm not sure how best to express this. Should I add a `noreturn` macro to include/__llvm_libc_common.h? Then how would I express this in stdc.td? 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74949/new/

https://reviews.llvm.org/D74949