[libc-commits] [PATCH] D85779: [libc] Add strtok_r implementation.

[Chris Gyurgyik via Phabricator via libc-commits]

cgyurgyik marked an inline comment as done.
cgyurgyik added inline comments.


================
Comment at: libc/spec/posix.td:16
   ConstType ConstCharPtr = ConstType<CharPtr>;
+  RestrictedPtrType RestrictedCharPtr = RestrictedPtrType<CharType>;
+  ConstType ConstRestrictedCharPtr = ConstType<RestrictedCharPtr>;
----------------
sivachandra wrote:
> cgyurgyik wrote:
> > sivachandra wrote:
> > > Other restricted pointer types are named like `RestrictSigSetType`. For consistency, we should use just one style everywhere.
> > Are you saying at the file level, or the libc level? 
> > For example, in `.../spec/stdc.td`, it is named in the following manner:
> > `RestrictedPtrType CharRestrictedPtr = RestrictedPtrType<CharType>`. Which would we prefer?
> Keep it as in this patch then. We can cleanup separately.
Ok I'll make a note for myself to fix this in a later revision. Currently seeing if there's a clean way to use a single function for both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85779/new/

https://reviews.llvm.org/D85779