[libc-commits] [PATCH] D85779: [libc] Add strtok_r implementation.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Aug 12 12:13:55 PDT 2020
sivachandra added inline comments.
Comment at: libc/spec/posix.td:16
ConstType ConstCharPtr = ConstType<CharPtr>;
+ RestrictedPtrType RestrictedCharPtr = RestrictedPtrType<CharType>;
+ ConstType ConstRestrictedCharPtr = ConstType<RestrictedCharPtr>;
> sivachandra wrote:
> > Other restricted pointer types are named like `RestrictSigSetType`. For consistency, we should use just one style everywhere.
> Are you saying at the file level, or the libc level?
> For example, in `.../spec/stdc.td`, it is named in the following manner:
> `RestrictedPtrType CharRestrictedPtr = RestrictedPtrType<CharType>`. Which would we prefer?
Keep it as in this patch then. We can cleanup separately.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits