[libc-commits] [PATCH] D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D85790#2211927 <https://reviews.llvm.org/D85790#2211927>, @cgyurgyik wrote:

> In D85790#2211882 <https://reviews.llvm.org/D85790#2211882>, @sivachandra wrote:
>
>> @cgyurgyik - PTAL. The latest diff looks correct to me (as in, what I intended to upload) and includes a fix to `strstr`. Without the fix, a `strstr` test fails with the `nullptr` change to the tests.
>
> `strstr` change LGTM. Not familiar enough with test suite to make that call so I'll let abrachet LGTM this.

Thanks.

@abrachet, I think we can do something smarter here. For example, I don't like using `"<nullptr>"`. But I am not sure if the complexity is worth it. If required, we can always extend this. Feel free to let me know if you can think of a better approach without too much of moving things around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85790/new/

https://reviews.llvm.org/D85790