[libc-commits] [PATCH] D85790: [libc][NFC] Extend <ASSERT|EXPECT>_STR* macros to compare with nullptr.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 11 16:58:10 PDT 2020


cgyurgyik added a comment.

In D85790#2211882 <https://reviews.llvm.org/D85790#2211882>, @sivachandra wrote:

> @cgyurgyik - PTAL. The latest diff looks correct to me (as in, what I intended to upload) and includes a fix to `strstr`. Without the fix, a `strstr` test fails with the `nullptr` change to the tests.

`strstr` change LGTM. Not familiar enough with test suite to make that call so I'll let abrachet LGTM this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85790/new/

https://reviews.llvm.org/D85790



More information about the libc-commits mailing list