[libc-commits] [PATCH] D74021: Created uChar implementation for libc

Sat Aug 8 17:30:07 PDT 2020

MarcusJohnson91 added a comment.

Hey guys, I'm rebasing and starting work on this again, sorry for the wait I moved 2000 miles from Michigan to Oregon.

I have a question tho.

Uchar and wchar both rely on mbstate_t which is a global variable for their conversions.

I'm currently using an enum to hold the valid states different conversions can be in, and I'm wondering how it should all be layered together?

Should uchar depend on wchar, should wchar depend on uchar, should there be a private header that both of them use?

and also what about namespaces, should the enum be in a private namespace and the mbstate_t global be in a public namespace?

Any clarification would be great, thanks.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74021/new/

https://reviews.llvm.org/D74021