[libc-commits] [libc] f6d74b2 - [libc][NFC] Disable a loader test as ld.gold fails to link.

[Siva Chandra Reddy via libc-commits]

Author: Siva Chandra Reddy
Date: 2020-08-07T23:45:18-07:00
New Revision: f6d74b29d6dc437db983aabee0b2b6d6d3c52f56

URL: https://github.com/llvm/llvm-project/commit/f6d74b29d6dc437db983aabee0b2b6d6d3c52f56
DIFF: https://github.com/llvm/llvm-project/commit/f6d74b29d6dc437db983aabee0b2b6d6d3c52f56.diff

LOG: [libc][NFC] Disable a loader test as ld.gold fails to link.

Will be reenabled after investigating and fixing the problem.

Added: 
    

Modified: 
    libc/test/loader/linux/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/loader/linux/CMakeLists.txt b/libc/test/loader/linux/CMakeLists.txt
index b7899fa4c5c1..15d67a128194 100644
--- a/libc/test/loader/linux/CMakeLists.txt
+++ b/libc/test/loader/linux/CMakeLists.txt
@@ -36,16 +36,18 @@ add_loader_test(
     libc.loader.linux.crt1
 )
 
-add_loader_test(
-  loader_tls_test
-  SRC
-    tls_test.cpp
-  DEPENDS
-    libc.config.linux.app_h
-    libc.include.errno
-    libc.include.sys_mman
-    libc.loader.linux.crt1
-    libc.src.assert.__assert_fail
-    libc.src.errno.__errno_location
-    libc.src.sys.mman.mmap
-)
+# TODO: Disableing this test temporarily to investigate why gold fails to link
+# and produce an executable for this test. Test works all fine with ld.bfd.
+#add_loader_test(
+#  loader_tls_test
+#  SRC
+#    tls_test.cpp
+#  DEPENDS
+#    libc.config.linux.app_h
+#    libc.include.errno
+#    libc.include.sys_mman
+#    libc.loader.linux.crt1
+#    libc.src.assert.__assert_fail
+#    libc.src.errno.__errno_location
+#    libc.src.sys.mman.mmap
+#)