[flang-dev] [PATCH] D100897: [flang] Make 'team_number()' an intrinsic function

[Rasmussen, Craig E. via flang-dev]

  > clementval added a comment.
  > Looks like buildbots are failing with this revision. Can you have a look or revert?

I saw this problem and fixed it later that day with: [flang] 18e6328 - [flang] Remove incorrect unit test

I should probably point out that I had run check-flang before pushing the changes and noticed that flang-OldUnit was failing.  However I was confused (not unusual) because it is called OldUnit after all and I always get the accompanying failure, see below (so I ignored the failing test I actually caused):
------------------------------------------
FAIL: flang-OldUnit :: Evaluate/folding.test (786 of 931)
******************** TEST 'flang-OldUnit :: Evaluate/folding.test' FAILED ********************
/Users/rasmussen17/Compilers/llvm-project/flang/unittests/Evaluate/folding.cpp:64: FAIL: y1Flushing.IsInfinite() || std::abs(host::CastFortranToHost<R4>(y1Flushing) + 88.) > 2
73 tests pass, 1 test FAILS
------------------------------------------

I looked briefly at the failure at folding.cpp:64 and wonder if it only occurs on macs and must not be caught by the buildbot army.  I’ll take a look at it further down the line.

Cheers,
Craig

From: Valentin Clement via Phabricator <reviews at reviews.llvm.org>
Date: Monday, October 4, 2021 at 10:12 PM
To: Rasmussen, Craig E. <rasmussen17 at llnl.gov>, sscalpone at nvidia.com <sscalpone at nvidia.com>, pklausler at nvidia.com <pklausler at nvidia.com>, psteinfeld at nvidia.com <psteinfeld at nvidia.com>, jperier at nvidia.com <jperier at nvidia.com>
Cc: clementval at gmail.com <clementval at gmail.com>, Doerfert, Johannes <jdoerfert at anl.gov>, tim at tkeith.com <tim at tkeith.com>, llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>, flang-commits at lists.llvm.org <flang-commits at lists.llvm.org>, vigbalas at amd.com <vigbalas at amd.com>, rkauffmann at nvidia.com <rkauffmann at nvidia.com>, bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>, yanliang.mu at intel.com <yanliang.mu at intel.com>, Perry-Holby, Katherine Alexis <aperry at lanl.gov>, Shraiysh.Vaishay at amd.com <Shraiysh.Vaishay at amd.com>, quic_sourabhs at quicinc.com <quic_sourabhs at quicinc.com>, dougpuob at gmail.com <dougpuob at gmail.com>, isuruf at gmail.com <isuruf at gmail.com>, kiranchandramohan at gmail.com <kiranchandramohan at gmail.com>, eschweitz at nvidia.com <eschweitz at nvidia.com>, v.churavy at gmail.com <v.churavy at gmail.com>
Subject: [PATCH] D100897: [flang] Make 'team_number()' an intrinsic function
clementval added a comment.

Looks like buildbots are failing with this revision. Can you have a look or revert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://urldefense.us/v3/__https://reviews.llvm.org/D100897/new/__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyR1H_hrC$<https://urldefense.us/v3/__https:/reviews.llvm.org/D100897/new/__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyR1H_hrC$>

https://urldefense.us/v3/__https://reviews.llvm.org/D100897__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyc9uJszM$<https://urldefense.us/v3/__https:/reviews.llvm.org/D100897__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyc9uJszM$>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/flang-dev/attachments/20211013/65b1d44f/attachment.html>