<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Menlo;
panose-1:2 11 6 9 3 8 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"> > clementval added a comment.<br>
> Looks like buildbots are failing with this revision. Can you have a look or revert?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I saw this problem and fixed it later that day with: [flang] 18e6328 - [flang] Remove incorrect unit test<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I should probably point out that I had run check-flang before pushing the changes and noticed that flang-OldUnit was failing. However I was confused (not unusual) because it is called OldUnit after all and I always get the accompanying
failure, see below (so I ignored the failing test I actually caused):<o:p></o:p></p>
<p class="MsoNormal">------------------------------------------<o:p></o:p></p>
<p class="MsoNormal">FAIL: flang-OldUnit :: Evaluate/folding.test (786 of 931)<o:p></o:p></p>
<p class="MsoNormal">******************** TEST 'flang-OldUnit :: Evaluate/folding.test' FAILED ********************<o:p></o:p></p>
<p class="MsoNormal">/Users/rasmussen17/Compilers/llvm-project/flang/unittests/Evaluate/folding.cpp:64: FAIL: y1Flushing.IsInfinite() || std::abs(host::CastFortranToHost<R4>(y1Flushing) + 88.) > 2<o:p></o:p></p>
<p class="MsoNormal">73 tests pass, 1 test FAILS<o:p></o:p></p>
<p class="MsoNormal">------------------------------------------<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I looked briefly at the failure at folding.cpp:64 and wonder if it only occurs on macs and must not be caught by the buildbot army. I’ll take a look at it further down the line.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Cheers,<o:p></o:p></p>
<p class="MsoNormal">Craig<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Valentin Clement via Phabricator <reviews@reviews.llvm.org><br>
<b>Date: </b>Monday, October 4, 2021 at 10:12 PM<br>
<b>To: </b>Rasmussen, Craig E. <rasmussen17@llnl.gov>, sscalpone@nvidia.com <sscalpone@nvidia.com>, pklausler@nvidia.com <pklausler@nvidia.com>, psteinfeld@nvidia.com <psteinfeld@nvidia.com>, jperier@nvidia.com <jperier@nvidia.com><br>
<b>Cc: </b>clementval@gmail.com <clementval@gmail.com>, Doerfert, Johannes <jdoerfert@anl.gov>, tim@tkeith.com <tim@tkeith.com>, llvm-commits@lists.llvm.org <llvm-commits@lists.llvm.org>, flang-commits@lists.llvm.org <flang-commits@lists.llvm.org>, vigbalas@amd.com
<vigbalas@amd.com>, rkauffmann@nvidia.com <rkauffmann@nvidia.com>, bhuvanendra.kumarn@amd.com <bhuvanendra.kumarn@amd.com>, yanliang.mu@intel.com <yanliang.mu@intel.com>, Perry-Holby, Katherine Alexis <aperry@lanl.gov>, Shraiysh.Vaishay@amd.com <Shraiysh.Vaishay@amd.com>,
quic_sourabhs@quicinc.com <quic_sourabhs@quicinc.com>, dougpuob@gmail.com <dougpuob@gmail.com>, isuruf@gmail.com <isuruf@gmail.com>, kiranchandramohan@gmail.com <kiranchandramohan@gmail.com>, eschweitz@nvidia.com <eschweitz@nvidia.com>, v.churavy@gmail.com
<v.churavy@gmail.com><br>
<b>Subject: </b>[PATCH] D100897: [flang] Make 'team_number()' an intrinsic function<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">clementval added a comment.<br>
<br>
Looks like buildbots are failing with this revision. Can you have a look or revert?<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://urldefense.us/v3/__https:/reviews.llvm.org/D100897/new/__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyR1H_hrC$">
https://urldefense.us/v3/__https://reviews.llvm.org/D100897/new/__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyR1H_hrC$</a>
<br>
<br>
<a href="https://urldefense.us/v3/__https:/reviews.llvm.org/D100897__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyc9uJszM$">https://urldefense.us/v3/__https://reviews.llvm.org/D100897__;!!G2kpM7uM-TzIFchu!iDKXQ5Qdpuec-UCVxzBCAgc6ObafgySvdENLbIb9nNYeU2pQjNdamMK7klzqyc9uJszM$</a>
<o:p></o:p></p>
</div>
</div>
</body>
</html>