[flang-dev] Flang + CMake

[Andrzej Warzynski via flang-dev]

FYI, I've just opened an issue for this: 
https://gitlab.kitware.com/cmake/cmake/-/issues/22387

-Andrzej

On 02/07/2021 22:06, Andrzej Warzynski via flang-dev wrote:
> Hi Tin,
> 
> Thank you for taking a look at this!
> 
> * LLVM Flang - https://github.com/llvm/llvm-project/tree/main/flang
> * Classic Flang - https://github.com/flang-compiler/flang
> 
> IIUC, the existing identification in CMake is for "Classic Flang". We 
> want to preserve it - there will be a lot of developers that rely on it. 
> So for "LLVM Flang", we probably want to add something new rather then 
> modify the existing identification.
> 
> I'm not too concerned about the actual name, but I think that it would 
> be very beneficial if we abandoned the name "Flang" in favour of 
> something that uniquely identifies "Classic Flang" and "LLVM Flang". 
> Otherwise this gets too confusing.
> 
> In my original e-mail I was only referring to "LLVM Flang". It was my 
> incorrect assumption that the existing identification in CMake was 
> introduced for "LLVM Flang". Apologies for that.
> 
> -Andrzej
> 
> On 02/07/2021 18:25, Tin Huynh via flang-dev wrote:
>> Hi,
>>
>> I've been asked by Steve to take a look at Flang CMake integration as 
>> I have upstreamed the original flang integration in the past.
>>
>> I've taken a look and confirm that if we change the predefines that 
>> CMake looks for from upper case __FLANG to __flang__ (and other 
>> similar predefines) cmake will be able to identify and use flang.
>>
>> The question I want to pose is: what should we name this flang for 
>> cmake identification? There is already an existing flang 
>> identification in CMake that I assume people depend on. So we will 
>> need to duplicate the CMake identification bits for original flang 
>> into a different name. I would like suggestions for what to name it. 
>> (Perhaps llvm-flang?)
>>
>> I can set up the initial CMake identification for flang and create a 
>> pull request upstream, but going forward someone with more familiarity 
>> with flang's options should maintain it.
>>
>> Tin
>>
>>
>> _______________________________________________
>> flang-dev mailing list
>> flang-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev
>>
> _______________________________________________
> flang-dev mailing list
> flang-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev