[flang-commits] [flang] Fix #222168: reject DATA-style initializer on EXTERNAL/INTRINSIC (PR #222256)

[Adarsh Mishra via flang-commits]

Adarsh-Me wrote:

The three premerge workflows on `5c3d2c83c` are sitting at `action_required`, so nothing has actually compiled yet — GitHub holds CI for a fork PR from a first-time contributor until someone with write access approves the run. Could you approve them (Checks tab → "Approve and run workflows")? @eugeneepshteyn

That run is the one piece of verification I cannot produce myself: flang has not been built here, so `test_errors.py` has not been executed against the expanded `data28.f90`. It matters most for the four added cases — `s5` (`integer sum /1/` with no `INTRINSIC`/`EXTERNAL` statement, a plain local object that merely shares a name with an intrinsic) and `s6` (a `PROCEDURE` pointer initialiser, allowed by 8.6.7) both have to stay **silent**, and `test_errors.py` compares the complete diagnostic set per compilation rather than checking that expected messages appear. One extra note anywhere in the file fails it.

If `s5` or `s6` does draw a message then `IsProcedure` / `IsProcedurePointer` is not classifying that declaration the way the standard does, and I will push a fixup to the guard rather than adjust the expectations.


https://github.com/llvm/llvm-project/pull/222256