[flang-commits] [flang] Fix #222168: reject DATA-style initializer on EXTERNAL/INTRINSIC (PR #222256)

[Adarsh Mishra via flang-commits]

Adarsh-Me wrote:

@eugeneepshteyn the PR description is filled out now, since it becomes the commit message: it states the symptom (silently accepted and dropped `/initialization/`, order-dependent), the offending path (`DataChecker::Leave` handing the value list to `AccumulateDataInitializations` without checking the symbol class, and the `CHECK(designator.has_value())` crash for an intrinsic that is not an unrestricted specific function), the standards basis for rejecting it, and why procedure pointers keep the existing path.

The two review comments are answered inline on their own threads.

https://github.com/llvm/llvm-project/pull/222256