[flang-commits] [flang] [Flang] Don't create a hidden USE symbol for a same-name subprogram collision (PR #233665)

[via flang-commits]

keepyixiao wrote:

> The fix seems to be correct, but need better testing.
Also, the title and the last line of the commit message don't describe what the patch does. The change is in semantics and stops the hidden symbol from being created, so there is nothing left for lowering to avoid; something like "[flang] Don't create a hidden USE symbol for a same-name subprogram collision" would fit. "Add a regression test for an unused same-name CHARACTER pointer" does not hold for the test in its current form.

Thanks for the review. I updated the commit title and message to describe the semantics change accurately.

I also ran the Fortran tests in llvm-test-suite; all 6927 tests passed.

https://github.com/llvm/llvm-project/pull/233665