[flang-commits] [flang] [Flang] Don't create a hidden USE symbol for a same-name subprogram collision (PR #233665)

[via flang-commits]

================
@@ -4213,9 +4213,8 @@ bool ScopeHandler::ConvertToUseError(
         location,
         "'%s' is use-associated into a subprogram of the same name"_port_en_US,
         used.name());
-    SourceName created{context().GetTempName(currScope())};
-    Symbol &tmpUse{MakeSymbol(created, Attrs(), UseDetails{location, used})};
-    UseErrorDetails useError{tmpUse.get<UseDetails>()};
+    UseDetails useDetails{location, used};
----------------
keepyixiao wrote:

Agreed. I could not find any other use of the temporary symbol either.

https://github.com/llvm/llvm-project/pull/233665