[flang-commits] [flang] [flang][OpenMP] Properly resolve CRITICAL construct names (PR #205904)

[Krzysztof Parzyszek via flang-commits]

kparzysz wrote:

> I strongly recommend that these kinds of errors should be a warning, so that the user could promote them to errors or turn them off, depending on their needs. This behavior could be documented as OpenMP extension.

The original fix actually did that, but since I had to make changes to lowering to handle reserved identifiers where only a designator was expected before, I was worried that allowing this could open some unforeseen can of worms.

I can come up with a solution that improves how we deal with reserved names (and emits a warning instead) if you're willing to wait until next week.

https://github.com/llvm/llvm-project/pull/205904