[flang-commits] [flang] [flang][openacc] Fix DEFAULT(NONE) errors for array sections (PR #204248)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- flang/lib/Semantics/resolve-directives.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Semantics/resolve-directives.cpp b/flang/lib/Semantics/resolve-directives.cpp
index 19c9cf9c3..b67fed11d 100644
--- a/flang/lib/Semantics/resolve-directives.cpp
+++ b/flang/lib/Semantics/resolve-directives.cpp
@@ -1924,16 +1924,15 @@ static bool ContainsStructureComponent(const parser::DataRef &dataRef) {
 }
 
 static bool ContainsStructureComponent(const parser::Designator &designator) {
-  return common::visit(
-      common::visitors{
-          [](const parser::DataRef &dataRef) {
-            return ContainsStructureComponent(dataRef);
-          },
-          [](const parser::Substring &substring) {
-            return ContainsStructureComponent(
-                std::get<parser::DataRef>(substring.t));
-          },
-      },
+  return common::visit(common::visitors{
+                           [](const parser::DataRef &dataRef) {
+                             return ContainsStructureComponent(dataRef);
+                           },
+                           [](const parser::Substring &substring) {
+                             return ContainsStructureComponent(
+                                 std::get<parser::DataRef>(substring.t));
+                           },
+                       },
       designator.u);
 }
 
@@ -1970,7 +1969,8 @@ void AccAttributeVisitor::ResolveAccObject(
             const parser::Name &baseName{parser::GetFirstName(designator)};
             if (auto *symbol{ResolveAcc(baseName, accFlag, currScope())}) {
               AddToContextObjectWithDSA(*symbol, accFlag);
-              if (preciseDesignator && dataSharingAttributeFlags.test(accFlag)) {
+              if (preciseDesignator &&
+                  dataSharingAttributeFlags.test(accFlag)) {
                 CheckMultipleAppearances(
                     baseName, *symbol, accFlag, &accObject, preciseDesignator);
               }
@@ -2043,8 +2043,7 @@ void AccAttributeVisitor::CheckMultipleAppearances(const parser::Name &name,
     // real conflict that dedup would silently hide.
     auto firstFlag{GetContext().FindSymbolWithDSA(*target)};
     if (warnSameKindDuplicate && occurrence && firstFlag &&
-        *firstFlag == accFlag &&
-        accFlag != Symbol::Flag::AccReduction) {
+        *firstFlag == accFlag && accFlag != Symbol::Flag::AccReduction) {
       context_.Warn(common::UsageWarning::OpenAccUsage, name.source,
           "'%s' appears more than once in the same kind of data-sharing clause on an OpenACC directive; duplicate ignored"_warn_en_US,
           name.ToString());

``````````

</details>


https://github.com/llvm/llvm-project/pull/204248