[flang-commits] [flang] [mlir] [flang][OpenMP] Lower target in_reduction for host fallback (PR #199967)

[Sergio Afonso via flang-commits]

================
@@ -436,18 +436,28 @@ static void bindEntryBlockArgs(lower::AbstractConverter &converter,
               .first);
   };
 
-  // Process in clause name alphabetical order to match block arguments order.
   // Do not bind host_eval variables because they cannot be used inside of the
   // corresponding region, except for very specific cases handled separately.
+  //
+  // For `omp.task` / `omp.taskloop`, `in_reduction` list items have their own
+  // entry block argument and are bound here like other private-like variables.
----------------
skatrak wrote:

Nit: I don't think this comment adds any value here. We could be saying nearly the same about every other clause handled below, just swapping directive and clause names.

https://github.com/llvm/llvm-project/pull/199967