[flang-commits] [flang] [lld] [llvm] [mlir] [lld][bolt][flang][mlir] Avoid premature Twine .str() materialization (PR #204838)

[via flang-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- bolt/lib/Core/BinaryContext.cpp flang/lib/Optimizer/Dialect/FIROps.cpp flang/lib/Optimizer/OpenACC/Analysis/FIROpenACCSupportAnalysis.cpp lld/ELF/Driver.cpp lld/ELF/LTO.cpp lld/MachO/DriverUtils.cpp lld/MachO/ObjC.cpp mlir/lib/Transforms/ViewOpGraph.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp
index a67e3092c..3444a6c5c 100644
--- a/bolt/lib/Core/BinaryContext.cpp
+++ b/bolt/lib/Core/BinaryContext.cpp
@@ -1581,8 +1581,7 @@ void BinaryContext::foldFunction(BinaryFunction &ChildBF,
   // placeholder so that getSymbol() doesn't crash. In non-relocation mode,
   // this effectively renames the function.
   WriteCtxLock.lock();
-  ChildBF.getSymbols().push_back(
-      Ctx->getOrCreateSymbol("__ICF_" + ChildName));
+  ChildBF.getSymbols().push_back(Ctx->getOrCreateSymbol("__ICF_" + ChildName));
   WriteCtxLock.unlock();
 
   ChildBF.setFolded(&ParentBF);

``````````

</details>


https://github.com/llvm/llvm-project/pull/204838