[flang-commits] [clang] [clang-tools-extra] [flang] [lldb] [Clang] Refactor and consolidate color diagnostic handling (PR #202441)

[via flang-commits]

================
@@ -5074,7 +5077,7 @@ bool CompilerInvocation::CreateFromArgsImpl(
   ParseMigratorArgs(Res.getMigratorOpts(), Args, Diags);
   ParseAnalyzerArgs(Res.getAnalyzerOpts(), Args, Diags);
   ParseDiagnosticArgs(Res.getDiagnosticOpts(), Args, &Diags,
-                      /*DefaultDiagColor=*/false);
+                      /*DefaultDiagColor=*/true);
----------------
Sirraide wrote:

Hmm, seems like I missed a use somewhere then; in that case, doesn’t this already have a default parameter of `true`? In that case we can at least remove the explicit `true` argument here I’d say

https://github.com/llvm/llvm-project/pull/202441