[flang-commits] [flang] [Flang][Openmp]Prevent TODO abort on nothing directive (PR #202679)
via flang-commits
flang-commits at lists.llvm.org
Tue Jun 9 07:55:04 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- flang/lib/Lower/OpenMP/OpenMP.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp
index 7a6fa9f60..411abc362 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -5305,17 +5305,17 @@ static void genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx,
lower::pft::Evaluation &eval,
const parser::OmpUtilityDirective &dir) {
- common::visit(
- common::visitors{
- [&](const parser::OmpNothingDirective &) {
- // nothing-directive is a no-op (OpenMP 5.2 [8.4])
- },
- [&](const parser::OmpErrorDirective &) {
- if (!semaCtx.langOptions().OpenMPSimd)
- TODO(converter.getCurrentLocation(), "OmpErrorDirective");
- },
- },
- dir.u);
+ common::visit(common::visitors{
+ [&](const parser::OmpNothingDirective &) {
+ // nothing-directive is a no-op (OpenMP 5.2 [8.4])
+ },
+ [&](const parser::OmpErrorDirective &) {
+ if (!semaCtx.langOptions().OpenMPSimd)
+ TODO(converter.getCurrentLocation(),
+ "OmpErrorDirective");
+ },
+ },
+ dir.u);
}
static void genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
``````````
</details>
https://github.com/llvm/llvm-project/pull/202679
More information about the flang-commits
mailing list