[flang-commits] [flang] [mlir] [mlir][OpenMP] Add iterator support to map/motion clause (PR #197047)

[Sergio Afonso via flang-commits]

================
@@ -2553,9 +2555,7 @@ def AffinityEntryOp : OpenMP_Op<"affinity_entry", [Pure]> {
 // Iterator Op
 //===----------------------------------------------------------------------===//
 
-def IteratorOp : OpenMP_Op<"iterator",
-                           [AttrSizedOperandSegments,
-                            SingleBlockImplicitTerminator<"YieldOp">],
+def IteratorOp : OpenMP_Op<"iterator", [AttrSizedOperandSegments],
----------------
skatrak wrote:

By adding this, we also ensure all regions have terminators (see `SingleBlock::verifyTrait` in mlir/include/mlir/IR/OpDefinition.h), so `IteratorOp::verify` doesn't need the current changes to work around a potentially missing terminator.

```suggestion
def IteratorOp : OpenMP_Op<"iterator", [AttrSizedOperandSegments, SingleBlock],
```

https://github.com/llvm/llvm-project/pull/197047