[flang-commits] [flang] [flang][mlir] Add flang to mlir lowering for groupprivate (PR #180934)

[Sergio Afonso via flang-commits]

================
@@ -407,6 +426,8 @@ class SemanticsContext {
   UnorderedSymbolSet isUsed_;
   std::set<const parser::AccObject *> accObjectDuplicates_;
   std::list<ProgramTree> programTrees_;
+  std::map<SymbolRef, OmpGroupprivateDeviceType, SymbolAddressCompare>
+      ompGroupprivateDeviceTypes_;
----------------
skatrak wrote:

Have you considered storing this information into the `WithOmpDeclarative` mixin class instead of directly into the `SemanticsContext`? I guess this is a more recent change, but it is currently attached to e.g. `ObjectEntityDetails` and `CommonBlockDetails`, so the new `PutOmpGroupprivateDirective` could potentially be replaced with some additions to `PutOpenMPDeclarativeDirectives` and handled similarly to `declare_target` variables.

I think that would be a cleaner way to store and access this information.

https://github.com/llvm/llvm-project/pull/180934