[flang-commits] [flang] [flang][OpenMP] Refactor interface of WithOmpDeclarative (PR #200876)

[Sergio Afonso via flang-commits]

================
@@ -72,25 +72,35 @@ static void DumpList(llvm::raw_ostream &os, const char *label, const T &list) {
 
 llvm::raw_ostream &operator<<(
     llvm::raw_ostream &os, const WithOmpDeclarative &x) {
-  if (x.has_ompRequires() || x.has_ompAtomicDefaultMemOrder()) {
-    os << " OmpRequirements:(";
-    if (const common::OmpMemoryOrderType *admo{x.ompAtomicDefaultMemOrder()}) {
-      os << parser::ToLowerCaseLetters(llvm::omp::getOpenMPClauseName(
-                llvm::omp::Clause::OMPC_atomic_default_mem_order))
-         << '(' << parser::ToLowerCaseLetters(EnumToString(*admo)) << ')';
-      if (x.has_ompRequires()) {
+  using OmpClauseSet = WithOmpDeclarative::OmpClauseSet;
+
+  auto toLower = [](std::string_view sv) {
+    return parser::ToLowerCaseLetters(sv);
+  };
+  auto getLowerName = [&](llvm::omp::Clause c) {
----------------
skatrak wrote:

Nit: Feel free to ignore if you disagree, but it seems like defining this to just use it once seems more complex than just inlining it.

https://github.com/llvm/llvm-project/pull/200876