[flang-commits] [flang] [flang][test] fix false positive match in namelist.f90 test (PR #129075)
via flang-commits
flang-commits at lists.llvm.org
Thu Feb 27 08:06:42 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-fir-hlfir
Author: Tom Eccles (tblah)
<details>
<summary>Changes</summary>
Fixes #<!-- -->128855
"bbb" was matching the hashed identifier for the file name on some platforms. I have made this line more specific so that it does not match filename globals. The difference comes in fir.global *internal* vs fir.global *linkonce*.
---
Full diff: https://github.com/llvm/llvm-project/pull/129075.diff
1 Files Affected:
- (modified) flang/test/Lower/namelist.f90 (+1-1)
``````````diff
diff --git a/flang/test/Lower/namelist.f90 b/flang/test/Lower/namelist.f90
index ea97a0957c35b..9be8865234eae 100644
--- a/flang/test/Lower/namelist.f90
+++ b/flang/test/Lower/namelist.f90
@@ -140,5 +140,5 @@ subroutine rename_sub
write(*,bbb)
end
-! CHECK-NOT: bbb
+! CHECK-NOT: fir.global internal @_QQ{{.*}}bbb{{.*}} :
! CHECK: fir.string_lit "aaa\00"(4) : !fir.char<1,4>
``````````
</details>
https://github.com/llvm/llvm-project/pull/129075
More information about the flang-commits
mailing list