[flang-commits] [flang] [flang][test] fix false positive match in namelist.f90 test (PR #129075)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Thu Feb 27 08:06:09 PST 2025


https://github.com/tblah created https://github.com/llvm/llvm-project/pull/129075

Fixes #128855

"bbb" was matching the hashed identifier for the file name on some platforms. I have made this line more specific so that it does not match filename globals. The difference comes in fir.global *internal* vs fir.global *linkonce*.

>From 7118b1eb759df61662e1367d6fc29eeb92c483bf Mon Sep 17 00:00:00 2001
From: Tom Eccles <tom.eccles at arm.com>
Date: Thu, 27 Feb 2025 16:00:42 +0000
Subject: [PATCH] [flang][test] fix false positive match in namelist.f90 test

Fixes #128855

"bbb" was matching the hashed identifier for the file name on some
platforms. I have made this line more specific so that it does not match
filename globals. The difference comes in fir.global *internal* vs
fir.global *linkonce*.
---
 flang/test/Lower/namelist.f90 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/flang/test/Lower/namelist.f90 b/flang/test/Lower/namelist.f90
index ea97a0957c35b..9be8865234eae 100644
--- a/flang/test/Lower/namelist.f90
+++ b/flang/test/Lower/namelist.f90
@@ -140,5 +140,5 @@ subroutine rename_sub
   write(*,bbb)
 end
 
-! CHECK-NOT:   bbb
+! CHECK-NOT:   fir.global internal @_QQ{{.*}}bbb{{.*}} :
 ! CHECK:       fir.string_lit "aaa\00"(4) : !fir.char<1,4>



More information about the flang-commits mailing list