[flang-commits] [flang] [flang] Generalized simplification of HLFIR reduction ops. (PR #136071)

Thu Apr 17 15:52:31 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-clang` running on `as-builder-7` while building `flang` at step 7 "build-flang-default".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/7/builds/13594

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-flang-default) failure: cmake (failure)
...
51.349 [128/47/7605] Linking CXX executable bin/llvm-split
51.398 [128/46/7606] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/LowerHLFIROrderedAssignments.cpp.o
51.405 [128/45/7607] Linking CXX static library lib/libFIRDialect.a
51.447 [125/47/7608] Linking CXX static library lib/libFIRCodeGenDialect.a
51.467 [125/46/7609] Linking CXX static library lib/libCUFDialect.a
51.522 [125/45/7610] Linking CXX static library lib/libHLFIRDialect.a
52.037 [125/44/7611] Linking CXX executable bin/clang-tidy
53.110 [125/43/7612] Linking CXX executable bin/llvm-reduce
53.343 [125/42/7613] Linking CXX executable bin/opt
54.753 [125/41/7614] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o
FAILED: tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/flang/lib/Optimizer/Builder -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/Builder -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/../mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/clang/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o -MF tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o.d -o tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp: In function ‘llvm::SmallVector<mlir::Value> hlfir::genLBounds(mlir::Location, fir::FirOpBuilder&, hlfir::Entity)’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp:686:10: error: could not convert ‘lbounds’ from ‘SmallVector<[...],15>’ to ‘SmallVector<[...],6>’
  686 |   return lbounds;
      |          ^~~~~~~
      |          |
      |          SmallVector<[...],15>
55.017 [125/40/7615] Linking CXX executable bin/clangd-indexer
55.598 [125/39/7616] Linking CXX executable bin/clangd-fuzzer
55.834 [125/38/7617] Building CXX object tools/flang/lib/Optimizer/OpenACC/CMakeFiles/FIROpenACCSupport.dir/FIROpenACCTypeInterfaces.cpp.o
56.215 [125/37/7618] Linking CXX executable bin/clangd
57.473 [125/36/7619] Building CXX object tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/HlfirIntrinsics.cpp.o
58.203 [125/35/7620] Building CXX object tools/flang/lib/Optimizer/OpenMP/CMakeFiles/FlangOpenMPTransforms.dir/MapInfoFinalization.cpp.o
58.318 [125/34/7621] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/BufferizeHLFIR.cpp.o
60.768 [125/33/7622] Linking CXX executable bin/mlir-translate
61.981 [125/32/7623] Linking CXX executable bin/mlir-runner
67.074 [125/31/7624] Building CXX object tools/mlir/tools/mlir-query/CMakeFiles/mlir-query.dir/mlir-query.cpp.o
67.555 [125/30/7625] Building CXX object tools/mlir/tools/mlir-rewrite/CMakeFiles/mlir-rewrite.dir/mlir-rewrite.cpp.o
69.960 [125/29/7626] Building CXX object tools/mlir/tools/mlir-lsp-server/CMakeFiles/mlir-lsp-server.dir/mlir-lsp-server.cpp.o
70.663 [125/28/7627] Building CXX object tools/flang/tools/fir-lsp-server/CMakeFiles/fir-lsp-server.dir/fir-lsp-server.cpp.o
73.313 [125/27/7628] Building CXX object tools/mlir/tools/mlir-reduce/CMakeFiles/mlir-reduce.dir/mlir-reduce.cpp.o
74.441 [125/26/7629] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o
FAILED: tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/flang/lib/Optimizer/HLFIR/Transforms -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/../mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/build/flang/tools/clang/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o -MF tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o.d -o tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::genReductionInitValues() [with T = hlfir::MaxlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:482:1:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:500:10: error: could not convert ‘result’ from ‘SmallVector<[...],17>’ to ‘SmallVector<[...],6>’
  500 |   return result;
      |          ^~~~~~
      |          |
      |          SmallVector<[...],17>
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::reduceOneElement(const llvm::SmallVectorImpl<mlir::Value>&, hlfir::Entity, mlir::ValueRange) [with T = hlfir::MaxlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:505:1:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-clang/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:547:10: error: could not convert ‘newIndices’ from ‘SmallVector<[...],17>’ to ‘SmallVector<[...],6>’
  547 |   return newIndices;
      |          ^~~~~~~~~~
      |          |
      |          SmallVector<[...],17>

```

</details>

https://github.com/llvm/llvm-project/pull/136071