[flang-commits] [flang] [flang] Generalized simplification of HLFIR reduction ops. (PR #136071)

Thu Apr 17 15:47:40 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-gcc` running on `as-builder-7` while building `flang` at step 6 "build-flang-rt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/152/builds/1999

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-flang-rt) failure: cmake (failure)
...
47.081 [22/32/6617] Linking CXX executable bin/llvm-jitlink
54.014 [22/31/6618] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/InlineElementals.cpp.o
54.103 [22/30/6619] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/InlineHLFIRAssign.cpp.o
54.266 [22/29/6620] Linking CXX executable bin/llvm-lto
54.425 [22/28/6621] Linking CXX executable bin/opt
54.559 [22/27/6622] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/TemporaryStorage.cpp.o
55.536 [22/26/6623] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/OptimizedBufferization.cpp.o
56.261 [22/25/6624] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/ConvertToFIR.cpp.o
57.705 [22/24/6625] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/LowerHLFIROrderedAssignments.cpp.o
59.926 [22/23/6626] Building CXX object tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o
FAILED: tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o 
ccache /usr/bin/g++ -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/flang/lib/Optimizer/Builder -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/Builder -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/llvm/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/../mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/clang/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o -MF tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o.d -o tools/flang/lib/Optimizer/Builder/CMakeFiles/FIRBuilder.dir/HLFIRTools.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp: In function ‘llvm::SmallVector<mlir::Value> hlfir::genLBounds(mlir::Location, fir::FirOpBuilder&, hlfir::Entity)’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/Builder/HLFIRTools.cpp:686:10: error: could not convert ‘lbounds’ from ‘SmallVector<[...],15>’ to ‘SmallVector<[...],6>’
  686 |   return lbounds;
      |          ^~~~~~~
      |          |
      |          SmallVector<[...],15>
59.998 [22/22/6627] Linking CXX executable bin/clang-21
61.873 [22/21/6628] Building CXX object tools/flang/lib/Optimizer/OpenACC/CMakeFiles/FIROpenACCSupport.dir/FIROpenACCTypeInterfaces.cpp.o
63.144 [22/20/6629] Building CXX object tools/flang/lib/Optimizer/OpenMP/CMakeFiles/FlangOpenMPTransforms.dir/MapInfoFinalization.cpp.o
63.885 [22/19/6630] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/BufferizeHLFIR.cpp.o
76.485 [22/18/6631] Building CXX object tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/HlfirIntrinsics.cpp.o
77.474 [22/17/6632] Building CXX object tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o
FAILED: tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o 
ccache /usr/bin/g++ -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/flang/lib/Optimizer/HLFIR/Transforms -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/flang/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/llvm/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/../mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/mlir/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/clang/include -isystem /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-ctad-maybe-unsupported -fno-strict-aliasing -fno-semantic-interposition -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o -MF tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o.d -o tools/flang/lib/Optimizer/HLFIR/Transforms/CMakeFiles/HLFIRTransforms.dir/SimplifyHLFIRIntrinsics.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::genReductionInitValues() [with T = hlfir::MaxlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:482:1:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:500:10: error: could not convert ‘result’ from ‘SmallVector<[...],17>’ to ‘SmallVector<[...],6>’
  500 |   return result;
      |          ^~~~~~
      |          |
      |          SmallVector<[...],17>
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::reduceOneElement(const llvm::SmallVectorImpl<mlir::Value>&, hlfir::Entity, mlir::ValueRange) [with T = hlfir::MaxlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:505:1:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:547:10: error: could not convert ‘newIndices’ from ‘SmallVector<[...],17>’ to ‘SmallVector<[...],6>’
  547 |   return newIndices;
      |          ^~~~~~~~~~
      |          |
      |          SmallVector<[...],17>
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::genReductionInitValues() [with T = hlfir::MinlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:482:1:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:500:10: error: could not convert ‘result’ from ‘SmallVector<[...],17>’ to ‘SmallVector<[...],6>’
  500 |   return result;
      |          ^~~~~~
      |          |
      |          SmallVector<[...],17>
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp: In instantiation of ‘llvm::SmallVector<mlir::Value> {anonymous}::MinMaxlocAsElementalConverter<T>::reduceOneElement(const llvm::SmallVectorImpl<mlir::Value>&, hlfir::Entity, mlir::ValueRange) [with T = hlfir::MinlocOp]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp:505:1:   required from here

```

</details>

https://github.com/llvm/llvm-project/pull/136071