[flang-commits] [flang] [flang][OpenMP]Add TODO for unsupported OpenMP taskwait depend feature (PR #111158)
via flang-commits
flang-commits at lists.llvm.org
Fri Oct 4 06:53:55 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-fir-hlfir
Author: Mats Petersson (Leporacanthicus)
<details>
<summary>Changes</summary>
Instead of asserting (debug) or not producing any code (release), tell user that `taskwait depend` this won't work.
---
Full diff: https://github.com/llvm/llvm-project/pull/111158.diff
1 Files Affected:
- (modified) flang/lib/Lower/OpenMP/OpenMP.cpp (+3)
``````````diff
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp
index 60c83586e468b6..a8c057e52e20ff 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -2604,6 +2604,9 @@ static void genOMP(
std::get<parser::OmpClauseList>(simpleStandaloneConstruct.t), semaCtx);
mlir::Location currentLocation = converter.genLocation(directive.source);
+ if (directive.v == llvm::omp::Directive::OMPD_taskwait && !clauses.empty())
+ TODO(converter.getCurrentLocation(), "taskwait with depend unsupported");
+
ConstructQueue queue{
buildConstructQueue(converter.getFirOpBuilder().getModule(), semaCtx,
eval, directive.source, directive.v, clauses)};
``````````
</details>
https://github.com/llvm/llvm-project/pull/111158
More information about the flang-commits
mailing list