[flang-commits] [flang] [flang][OpenMP]Add TODO for unsupported OpenMP taskwait depend feature (PR #111158)
Mats Petersson via flang-commits
flang-commits at lists.llvm.org
Fri Oct 4 06:53:21 PDT 2024
https://github.com/Leporacanthicus created https://github.com/llvm/llvm-project/pull/111158
Instead of asserting (debug) or not producing any code (release), tell user that `taskwait depend` this won't work.
>From 42ab9bde9b85a0ae7d90c3ac467f9a4d55980356 Mon Sep 17 00:00:00 2001
From: Mats Petersson <mats.petersson at arm.com>
Date: Fri, 4 Oct 2024 13:49:23 +0100
Subject: [PATCH] [flang][OpenMP]Add TODO for unsupported OpenMP taskwait
depend feature
Instead of crashing (debug) or not producing any code (release), tell
user that `taskwait depend` this won't work.
---
flang/lib/Lower/OpenMP/OpenMP.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp b/flang/lib/Lower/OpenMP/OpenMP.cpp
index 60c83586e468b6..a8c057e52e20ff 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -2604,6 +2604,9 @@ static void genOMP(
std::get<parser::OmpClauseList>(simpleStandaloneConstruct.t), semaCtx);
mlir::Location currentLocation = converter.genLocation(directive.source);
+ if (directive.v == llvm::omp::Directive::OMPD_taskwait && !clauses.empty())
+ TODO(converter.getCurrentLocation(), "taskwait with depend unsupported");
+
ConstructQueue queue{
buildConstructQueue(converter.getFirOpBuilder().getModule(), semaCtx,
eval, directive.source, directive.v, clauses)};
More information about the flang-commits
mailing list