[flang-commits] [flang] [flang][NFC] use mlir::SymbolTable in lowering (PR #86673)

[via flang-commits]

jeanPerier wrote:

> I guess we could theoretically always build a symbol table for each builder (as it only needs to know the ModuleOp). Is the concern here that it would be too hard to keep in sync or that it would make instantiating a builder too slow?

Thanks for the review! It would be too slow, especially in the passes where FIROpBuilder are created on the fly. Creating a new SymbolTable from a ModuleOp requires doing a shallow walk of the module (linear with the number of function + global + deriver types).

https://github.com/llvm/llvm-project/pull/86673