[flang-commits] [flang] [flang][OpenMP] - Transform target offloading directives with dependencies during PFT to MLIR conversion (PR #85130)

[Kiran Chandramohan via flang-commits]

kiranchandramohan wrote:

The concern with this approach is that it is attempting early lowering or conversion of target dependencies. It also means there will be no lowering for target dependencies in MLIR. It is probably not good that there is no lowering for target dependencies in the OpenMP dialect when there is a representation for it.

The issue with the conversion OpenMP MLIR pass is that it introduces tasks wrapping target constructs only when there are dependencies. Why is it not there when there are no dependencies? If this is an LLVM openmp runtime-specific lowering or just matching what Clang is doing, then we can add it as part of a legalize-for-export kind of pass. Equivalently you could refactor the task dependence lowering in OpenMPIRBuilder and/or OpenMP Translation.

https://github.com/llvm/llvm-project/pull/85130