[flang-commits] [flang] [flang][OpenMP] Implement flexible OpenMP clause representation (PR #81621)

Krzysztof Parzyszek via flang-commits flang-commits at lists.llvm.org
Tue Mar 5 04:55:59 PST 2024


kparzysz wrote:

Thanks Kiran.  I expanded the PR description with additional information.

The creation of omp::Clause from parser::OmpClause can be done with a single function call:
```
makeClause(parser::OmpClause, semaCtx) -> omp::Clause
```
so the complexity of creating one is relatively small.  If we created them during PTF creation, we'd need to store them somewhere (in OmpClause itself?).  Replacing OmpClause with omp::Clause would require potentially invasive changes in the parser/semantics analyzer, plus it would deviate from the representations of other PFT nodes (specifically SomeExpr/MaybeExpr is not explicitly used in PFT, except in parser::Expr).

I'm not sure if this answers your question though.  Let me know if you'd like more information.

https://github.com/llvm/llvm-project/pull/81621


More information about the flang-commits mailing list